Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a key column rather than a placeholder for count agg #16599

Conversation

wence-
Copy link
Contributor

@wence- wence- commented Aug 19, 2024

Description

The "invalid" placeholder column does not work with the experimental prefetching setup.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@wence- wence- requested a review from a team as a code owner August 19, 2024 17:45
@wence- wence- requested review from isVoid and brandon-b-miller and removed request for a team August 19, 2024 17:45
@github-actions github-actions bot added Python Affects Python cuDF API. cudf.polars Issues specific to cudf.polars labels Aug 19, 2024
@wence- wence- added bug Something isn't working non-breaking Non-breaking change labels Aug 19, 2024
@wence- wence- merged commit 13a1493 into rapidsai:feature/cudf-polars Aug 21, 2024
80 of 81 checks passed
@wence- wence- deleted the wence/fix/remove-placeholder-column branch August 21, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cudf.polars Issues specific to cudf.polars non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants